Skip to content

WIP: do not query for node name from api for metrics resource #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WIP: do not query for node name from api for metrics resource #2394

wants to merge 5 commits into from

Conversation

@haircommander
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 4, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2025
@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from rphillips and sjenning August 4, 2025 20:08
@haircommander
Copy link
Member Author

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-rt 4

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2025

@haircommander: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-rt

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/34e20ca0-7174-11f0-844a-dd96e8b37473-0

@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@haircommander
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@haircommander
Copy link
Member Author

/payload-job periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2025

@haircommander: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3bdc52f0-7943-11f0-81b3-d4ce7b481974-0

@haircommander
Copy link
Member Author

/payload-job periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2025

@haircommander: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a041d630-794c-11f0-930e-b89352640fc5-0

@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@haircommander
Copy link
Member Author

/payload-job periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2025

@haircommander: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6f397860-794f-11f0-8044-9efb1b9469a0-0

@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Aug 21, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@haircommander
Copy link
Member Author

/test e2e-aws-ovn-runc
/test e2e-aws-ovn-cgroupsv2

@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/test e2e-aws-ovn-crun

@haircommander
Copy link
Member Author

/retest

@haircommander haircommander mentioned this pull request Aug 27, 2025
Open
@rsevilla87 rsevilla87 mentioned this pull request Sep 2, 2025
Merged
1 task
@openshift-ci-robot
Copy link

@haircommander: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2025

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 85ed8ee link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-ovn-dualstack 85ed8ee link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-openstack-csi-manila 85ed8ee link false /test e2e-openstack-csi-manila
ci/prow/e2e-openstack-csi-cinder 85ed8ee link false /test e2e-openstack-csi-cinder
ci/prow/e2e-aws 85ed8ee link false /test e2e-aws
ci/prow/k8s-e2e-gcp-five-control-plane-replicas 85ed8ee link false /test k8s-e2e-gcp-five-control-plane-replicas
ci/prow/okd-scos-e2e-aws-ovn ac290bc link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview ac290bc link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-ipv6 ac290bc link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-crun-wasm ac290bc link true /test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-crun ac290bc link true /test e2e-aws-ovn-crun
ci/prow/e2e-aws-ovn-cgroupsv2 ac290bc link true /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-gcp ac290bc link true /test e2e-gcp
ci/prow/e2e-aws-ovn-fips ac290bc link true /test e2e-aws-ovn-fips
ci/prow/k8s-e2e-gcp-ovn ac290bc link true /test k8s-e2e-gcp-ovn
ci/prow/e2e-aws-ovn-techpreview-serial ac290bc link false /test e2e-aws-ovn-techpreview-serial
ci/prow/e2e-aws-ovn-serial ac290bc link true /test e2e-aws-ovn-serial
ci/prow/verify ac290bc link true /test verify
ci/prow/e2e-aws-ovn-runc ac290bc link true /test e2e-aws-ovn-runc
ci/prow/unit ac290bc link true /test unit
ci/prow/verify-commits ac290bc link true /test verify-commits

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rsevilla87
Copy link
Member

/payload-job periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

@openshift-ci
Copy link

openshift-ci bot commented Sep 10, 2025

@rsevilla87: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f1ea1e00-8e52-11f0-96a8-e70eb5d95cc6-0

@chentex
Copy link

chentex commented Sep 24, 2025

/payload-job periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2025

@chentex: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c7c2d290-992c-11f0-8a1d-4caebfa993ad-0

@chentex
Copy link

chentex commented Oct 10, 2025

/payload-job periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

@chentex: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-payload-control-plane-6nodes

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ecf0dda0-a5d9-11f0-9fa9-6ac9f825623e-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rphillips rphillips Awaiting requested review from rphillips

@sjenning sjenning Awaiting requested review from sjenning

Assignees

No one assigned

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haircommander @openshift-ci-robot @rsevilla87 @chentex @tkashem